Add functionality for websocket listening #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can you fix the failing code checks? See https://github.com/rhasspy/rhasspy-client/runs/461537051?check_suite_focus=true |
|
Oh wow, just seeing this. I can jump on the problems ASAP |
koenvervloesem
requested changes
Oct 18, 2020
| @@ -105,7 +108,7 @@ async def main(): | |||
|
|
|||
| # Begin client session | |||
| async with aiohttp.ClientSession() as session: | |||
| client = RhasspyClient(args.api_url, session) | |||
| client = RhasspyClient(args.api_host, args.api_port, session) | |||
There was a problem hiding this comment.
The secure parameter you added to RhasspyClient.__init__ isn't used in the main function. Shouldn't you add an argument to the argument parser to use https/wss? I also think tls (and the corresponding --tls argument) is more descriptive than secure.
There was a problem hiding this comment.
I'd agree with that. It'll be a little while before I can get back to this but I can fix when I have time
|
@logasja Are you still working on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to define a function that handles events from web sockets (might be good to have it start a new task when doing so)