x86_64: build with -mabi=ms .#812
Draft
vathpela wants to merge 5 commits into
Draft
Conversation
This adds a small amount to our logs like such: pe.c:863:handle_image() Loading section 0 ".text" at 0x7C34E000 pe.c:863:handle_image() Loading section 1 ".data" at 0x7C368000 pe.c:863:handle_image() Loading section 2 "mods" at 0x7C379000 pe.c:863:handle_image() Loading section 3 ".sbat" at 0x7C725000 Signed-off-by: Peter Jones <pjones@redhat.com>
This splits the arch-specific ARCH_CFLAGS into two variables, ARCH_TEST_CFLAGS (used for "make test"), and ARCH_CFLAGS (for everything else), which is generally expected to be a superset of the former. Signed-off-by: Peter Jones <pjones@redhat.com>
This moves shim/fb/mm's read-only data to its own section, so that it can properly be read-only. Signed-off-by: Peter Jones <pjones@redhat.com>
This patch changes shim on x86_64 to be built entirely with the Microsoft x64 ABI. In doing so it adds a macro "SYSVAPI" that corresponds with the opposite of EFIAPI, and uses that to declare the legacy shim lock protocol. This improves a number of things, not least it means if there's a bug in shim, the firmware backtrace code should be able to show an accurate dump of the call stack. Signed-off-by: Peter Jones <pjones@redhat.com>
More recent gnu-efi accepts two separate build variables, OPTIMIZATION_CFLAGS and DEBUG_CFLAGS, to set optimizations and debuginfo generating arguments. This adds those, setting OPTIMIZATION_CFLAGS to our internal OPTIMIZATIONS variable, and DEBUG_CFLAGS to "-ggdb -gdwarf-4 -gstrict-dwarf". With these, gdb can give us backtraces from shim all the way up into EFI. Signed-off-by: Peter Jones <pjones@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.