RHEL-9: Fix download of stage2 image from .treeinfo#6367
Merged
jkonecny12 merged 7 commits intorhinstaller:rhel-9from May 13, 2025
Merged
RHEL-9: Fix download of stage2 image from .treeinfo#6367jkonecny12 merged 7 commits intorhinstaller:rhel-9from
jkonecny12 merged 7 commits intorhinstaller:rhel-9from
Conversation
Member
Author
|
Manual testing required. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @jkonecny12 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment explaining why the whitespace trimming is necessary in
config_get. - The unit test file should be located in the same directory as the script being tested.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 3 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
jkonecny12
added
the
ready to merge
Member
Author
|
/kickstart-test --testtype smoke |
jkonecny12
removed
the
ready to merge
Member
Author
|
/kickstart-test --testtype smoke |
With commit 0785531 the `get_config` function in anaconda-lib.sh was broken because missing quotes removed leading and trailing whitespace characters automatically but after the fix in commit mentioned above this side effect was fixed which lead in broken code. In other words the key were never matched because of trailing whitespace. Issue raised by this is not being able to read .treeinfo and .buildstamp files in Dracut. Example of such situation is broken boot when stage2 image is stored under special path mentioned in .treeinfo file. (cherry picked from commit 2336ba8) Related: RHEL-48837
In Dracut the URL concatenation from .treeinfo could also point you to directory above by `..`. However, if the `inst.repo=` argument was set with trailing `/` it will create URL which is not supported by curl. Supported: `os/../BaseOS/` Unsupported by curl: `os//../BaseOS/` Remove the trailing `/` to avoid this issue. (cherry picked from commit 5cb0300) Resolves: RHEL-48837
This commit will also add code to enable testing of the Dracut shell scripts. (cherry picked from commit 69da1b4) Related: RHEL-48837
Dracut testing should be more versatile with this approach. This is more an extension for future testing. (cherry picked from commit 29debf1) Related: RHEL-48837
For better visibility that we have such a tests. (cherry picked from commit 7e9ed4e) Related: RHEL-48837
- Remove outdated parts - Fix minor issues - Add missing parts - Improve security topics Related: RHEL-48837
Related: RHEL-48837
jkonecny12
force-pushed
the
rhel-9-fix-updir-unified-iso
branch
from
579e95b to
3292977
Compare
Member
Author
|
/kickstart-test --testtype smoke |
KKoukiou
approved these changes
Apr 28, 2025
jkonecny12
added
the
ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is fix to enable downloading stage2 image from a non default place with .treeinfo file. If .treeinfo has a path to the stage2 image it will be used as the first variant, in case this will fail it will fallback to default paths.
This is fixing a few parts:
Backport of #5773
Resolves: RHEL-48837