Scaffold project and generate alertmanager dashboard #1
Conversation
| return fmt.Errorf("failed to convert json to yaml: %w", err) | ||
| } | ||
|
|
||
| err = os.WriteFile(fmt.Sprint(dashboardPath, filename), b, 0644) |
There was a problem hiding this comment.
I'd do a os.mkdir, just in case
There was a problem hiding this comment.
this actually fails in terms of idempotency when i added it
|
|
||
| err = writeDashboardFile(fileOut, j) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to write dashboard file: %w", err) |
There was a problem hiding this comment.
Let's just panic everywhere. I don't really think returning errors anywhere would help if something were broken
There was a problem hiding this comment.
from my understand, from reading the mage docs this s the preferred way because if we start to chain things together then, in targets like mage dashboards we can still build the majority of the work without having to bomb out
There was a problem hiding this comment.
I see, yeah we can follow mage best practices. Although, in our case, would it really matter. Majority of work is the final jsonnet gen step I guess. I'm fine either way
philipgough
force-pushed
the
am-dashboard
branch
from
0c9ec0d to
a6451ab
Compare
The result of
mage dashboards:alertmanageris output toresources/dashboard/alertmanager.yamland is exact as rhobs/configuration#723