Rebellion Pro Guitar/Bass/Keys Upgrade

[Luna65k]

Added Pro Guitar/Bass/Keys

Pro guitar follows 5-lane chart and doesn't add a new notes to 5-lane.
Tunning is Drop D (C#) in game

The backing track does have some audio on keys

https://www.youtube.com/watch?v=lLA2kQ2d-vk

[exoticri]

Please redo your dta to match the official port and remove every track in the midi except for the pro strings, keys, and venue tracks

[exoticri]

Please also rename the midi to rebellion_plus

[Luna65k]

Please redo your dta to match the official port and remove every track in the midi except for the pro strings, keys, and venue tracks

I didn't change the venue track for keys

[exoticri]

venue track should still remain regardless

[Luna65k]

Please redo your dta to match the official port and remove every track in the midi except for the pro strings, keys, and venue tracks

Midi should be fixed

[jdk13]

Please also split the pro guitar and pro bass tracks into a separate midi file, add it and the upgrades.dta file into its own folder in the pro strings rock band 4 dlc folder, as well as reduce the tuning entries down into regular Drop D. It may be played in Drop C# but tunings are reduced down to it's simplified form. And don't forget to add a tuning entries into the readme file included in the pro strings dlc folder!

[jdk13]

Now that you have hopefully correctly formatted your PR, I took a look through the Pro Guitar Upgrade (someone else can review keys)

First off, you seem to have left in all the 5 Lane Guitar Events in the Pro G/B tracks, Pro G/B tracks only require the Track Name event, Trainers, and custom chord names (if the song requires them but this one doesn't)

I'd also like to encourage not using CAT for generating Reductions, Chord Names, and Left hand Positions (LHP). As it often can miss LHP notes that can lead to breaking/changing notes in game. Only place LHP notes down for when your hand is required to move to a new position to be able to fret a section. There shouldn't be a Left Hand note for every note!

CAT's reductions also function by directly taking all the notes of EMH from the 5 Lane chart, Pro Guitar and Bass reductions do not function this way and have their own guidelines. https://discord.com/channels/961352072140324924/986378977247641600/1193681204201922600 Feel free to examine this pinned message in the rb_plus channel for help. Also note that this isn't a hard rule for every chart but you also must use your best judgement in order to figure out proper and smooth reductions for EMH

Cat also does not generate good chord names. All it does is take the lowest note and uses it as the name of a chord. But often times there are many chords where the name isn't determined by the lowest note, and it also doesn't take into consideration different tunings. There shouldn't be a new chord name note for every single note in the song!

On top of this, since your song is in Drop Db (-3 -1 -1 -1 -1 -1), the dta and chord names must be in Drop D as Drop D is the most simplified version of Drop D flat. This is how harmonix deals with special tunings. So a power chord in Pro Guitar that consists of (12-12) is not D flat but rather D. Actually as I'm writing this I've discovered it's in Drop C not D flat but the same still applies, everything in Drop D please.

As for the notes themselves, For Pro Guitar I dont quite think the notes sound quite right at around measure 21-28, might be a tuning thing? They sound like a key off or in a different key. Bass is good but just apply the changes I noted above, The expert chart can stay the same.

Thanks!

[jdk13]

Oh and one more thing, the dta file in the Pro Strings folder should be named "upgrades.dta", and make you give the Instrument tiers real ranks! Avoid using the default value, as it gets bunched up with Customs and RBN, causing ranks to be sorted by Alphabetical order when you sort by difficulty instead of sorting by difficulty!

[jdk13]

For the Pro strings, the file that is called songs.dta should be the one named upgrades.dta instead of the current one

the file that is called upgrades.dta should be deleted as that is incorrect tuning

The tuning table should also be named showing | Rebellion (ft. Daron Malakian) | Linkin park | G: Drop D
B: Drop D| G: Drop C
B: Drop C |

also did something happen to the pro guitar midi? it's blank, it needs to have the 17 fret chart of Pro Guitar and Bass (and if there's a 22 fret chart it needs to be included in as well)

Someone will need to review keys as I cannot comment on that