Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing path separator #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add missing path separator #2

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 27, 2013

Missing slash in tmpdir path on Ubuntu 13.10, due to tmpdir not ending with a slash like it does on OS X and Windows.

CompilerException java.io.FileNotFoundException: /tmpharmonikit.scsyndef (Permission denied), compiling:(harmonikit.clj:277:1)

@ghost
Copy link
Author

ghost commented Nov 27, 2013

Ah, I'm guessing this has to do with http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4391434. I'm on Ubuntu 13.10. That would also explain why you hadn't seen this yet. I don't have access to a Mac to verify the default tmpdir ends with a slash.

@richhickey
Copy link
Owner

tmpdir does end in slash on the Mac, which is why the original code worked for me, and this probably won't.

@ghost
Copy link
Author

ghost commented Nov 27, 2013

Double slashes in the path don't cause problems on Ubuntu. It seems like it would be best to have this logic in something like path-join, but it doesn't look like any existing library has this defined. I see that fs utils used to define fs/join [1], but it was removed from the latest version.

Do you want another pull request defining something like this within harmonikit?

[1] https://bitbucket.org/tebeka/fs/src/9a5476217d7101b1e20bf62866e8c4f368175ba1/src/fs.clj?at=default#cl-124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant