removed async/awaits from pagemodel core methods #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more (and last) portion of removing async/awaits.
Additionally I propose one breaking change: when _currentPage is null DisplayAlert and DisplayActionSheet methods should not silently work. According to current source code PageModelCoreMethods constructor invokes from ResolvePageModel only and in that case _currentPage should never be null, but let's say that by some reason it is. When I'm getting result from DisplayAlert I do expect that I'm getting user response and application business logic will rely on this. But with current implementation it is not true, because framework returned some value (false in that case). As for me NullPointerException is better than incorrect business logic, so I propose to remove "_currentPage != null" condition.