Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ruby 3.2 #143

Merged
merged 2 commits into from
Jun 30, 2024
Merged

Add support for Ruby 3.2 #143

merged 2 commits into from
Jun 30, 2024

Conversation

smortex
Copy link
Member

@smortex smortex commented Jan 10, 2024

Ruby 2.2 deprecated File#exists? in favor of File#exist?, and Ruby
3.2 removed the deprecated method.

We need to use the "new" method to run on Ruby 3.2.

Ruby 2.2 deprecated `File#exists?` in favor of `File#exist?`, and Ruby
3.2 removed the deprecated method.

We need to use the "new" method to run on Ruby 3.2.
@smortex
Copy link
Member Author

smortex commented Jun 11, 2024

@jamtur01, can you please approve the run of CI to see if my change help?

@smortex
Copy link
Member Author

smortex commented Jun 11, 2024

Oh, I also see that dependabot opened PRs to update dependencies. Maybe it is a better strategy than removing the Gemfile.lock… It is currently very outdated, and cannot work with recent versions of Ruby, so I think we must do something, either update it or remove it, but the current situation is not good!

This old bundle is broken with current ruby.  Allow to bundle using the
latest version of the dependencies that match the Gemfile.  This should
allow the test suite to run.
@smortex
Copy link
Member Author

smortex commented Jun 30, 2024

Oh, I also see that dependabot opened PRs to update dependencies. Maybe it is a better strategy than removing the Gemfile.lock… It is currently very outdated, and cannot work with recent versions of Ruby, so I think we must do something, either update it or remove it, but the current situation is not good!

I removed + regenerated the Gemfile.lock so that it indicates it was generated with a recent version of bundler instead of a legacy one. This avoids Ruby to use this legacy version of bundler with recent ruby that use legacy features which are not part of Ruby anymore. Dependabot will tell us when updates for dependencies will be available, and allows users to run the exact same bundle as the one used for unit testing if they want.

@jamtur01 jamtur01 merged commit 99d43f8 into riemann:main Jun 30, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants