Get rid of the Gemfile.lock #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lockfile allow reproducible build, which are awesome. However, we
also want to support multiple versions of Ruby, and a lockfile is
unfortunately not a one-size-fit-all solution in this case:
* Older versions of bundler cannot run on recent versions of Ruby;
* Recent versions of bundler cannot run on older versions of Ruby;
* Some dependencies are available for some versions of Ruby but not
all the ones we support, so a version of Ruby may be unable to run
the bundle generated by another version of Ruby.
The lock file is only used when someone clone the repository and run
`bundle install`. When installing with `gem install riemann-dash` (the
way recommanded in the README), the dependencies only have to be in the
bounds of what is authorized in the gemspec file, so this will only
affect a fraction of our users which are probably aware of what they are
doing.
This allows us to run the test suite on all supported versions of Ruby.
smortex
commented
Sep 24, 2024
| tzinfo (2.0.6) | ||
| concurrent-ruby (~> 1.0) | ||
| uri (0.13.0) | ||
| webrick (1.8.1) |
There was a problem hiding this comment.
We just received a notification saying that this version of webrick is vulnerable to HTTP Request Smuggling:
Getting rid of Gemfile.lock allows consumers to not depend on us for updating our dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lockfile allow reproducible build, which are awesome. However, we
also want to support multiple versions of Ruby, and a lockfile is
unfortunately not a one-size-fit-all solution in this case:
all the ones we support, so a version of Ruby may be unable to run
the bundle generated by another version of Ruby.
The lock file is only used when someone clone the repository and run
bundle install. When installing withgem install riemann-dash(theway recommanded in the README), the dependencies only have to be in the
bounds of what is authorized in the gemspec file, so this will only
affect a fraction of our users which are probably aware of what they are
doing.
This allows us to run the test suite on all supported versions of Ruby.