Fix riemann-haproxy with Ruby 3.0+
#273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
force-pushed
the
fix-riemann-haproxy
branch
from
9d99f9e
to
2ba5468
Compare
smortex
force-pushed
the
fix-riemann-haproxy
branch
from
2ba5468
to
da5c0fd
Compare
This tool has no tests. In order to fix it, add a test that prove that the code is currently wrong. Extract fetching HAProxy stats from parsing the CSV payload to make testing easier.
Ruby 3.0 fully separated keyword arguments from positional arguments. The `riemann-haproxy` tool has been broken with these versions of Ruby. Use the new syntax to unbreak the tool on these versions of Ruby.
smortex
changed the title
riemann-haproxy with Ruby 3.0
smortex
changed the title
riemann-haproxy with Ruby 3.0riemann-haproxy with Ruby 3.0+
|
@jamtur01 may I have a review please 😁? With the switch to Puppet 8 at $WORK we realized this tool is broken with Ruby 3. I would like to do a release to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3.0 and newer does not like passing a Hash in place of Keyword Arguments.
More info:
https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
Ensure we use a working syntax with all versions of Ruby supported by the gem.