some

rimecraft-rs · Mar 24, 2024 · b6fbc71 · b6fbc71
1 parent b3bd8d5
commit b6fbc71
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/crates/core/advancement/src/edcode.rs b/crates/core/advancement/src/edcode.rs
@@ -22,7 +22,7 @@ where
         // TODO: `RawText` doesn't implement edcode.
         // TODO: Encode `title` and `description`.
         self.icon.encode(&mut buf)?;
-        // Encode `frame`.
+        self.frame.encode(&mut buf)?;
         let mut i = 0_i32;
         if self.background.is_some() {
             i |= 1;

diff --git a/crates/core/advancement/src/lib.rs b/crates/core/advancement/src/lib.rs
@@ -115,8 +115,13 @@ where
 /// Describes how an advancement will be announced in the chat.
 /// # MCJE Reference
 /// `net.minecraft.advancement.AdvancementFrame` in yarn.
+#[cfg_attr(
+    feature = "edcode",
+    derive(::rimecraft_edcode::Encode, ::rimecraft_edcode::Decode)
+)]
 #[derive(Debug, Clone)]
 #[non_exhaustive]
+#[repr(u8)]
 pub enum Frame {
     /// Regular task.
     Task = 0,