Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edcode derive proc-macros for enum #38

Merged
merged 13 commits into from
Mar 23, 2024
Merged

Edcode derive proc-macros for enum #38

merged 13 commits into from
Mar 23, 2024

Conversation

0123456789-jpg
Copy link
Member

@0123456789-jpg 0123456789-jpg commented Mar 19, 2024 •
edited
Loading

Planned features:

  • Encode for enum
  • Decode for enum

JieningYu
JieningYu reviewed Mar 20, 2024
View reviewed changes
Copy link
Member

@JieningYu JieningYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rimecraft-edcode-derive crate name would be better

@0123456789-jpg 0123456789-jpg marked this pull request as ready for review March 23, 2024 14:16
@0123456789-jpg 0123456789-jpg changed the title Edcode derive proc-macros Edcode derive proc-macros for enum Mar 23, 2024
JieningYu
JieningYu requested changes Mar 23, 2024
View reviewed changes
crates/util/edcode-derive/Cargo.toml Outdated Show resolved Hide resolved
crates/util/edcode-derive/src/lib.rs Outdated Show resolved Hide resolved
crates/util/edcode-derive/src/lib.rs Show resolved Hide resolved
crates/util/edcode-derive/src/lib.rs Outdated Show resolved Hide resolved
crates/util/edcode-derive/src/lib.rs Outdated Show resolved Hide resolved
crates/util/edcode-derive/src/lib.rs Show resolved Hide resolved
crates/util/edcode-derive/src/lib.rs Show resolved Hide resolved
crates/util/edcode-derive/src/lib.rs Show resolved Hide resolved
JieningYu
JieningYu approved these changes Mar 23, 2024
View reviewed changes
Copy link
Member

@JieningYu JieningYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JieningYu JieningYu merged commit b4f67a2 into main Mar 23, 2024
2 checks passed
@JieningYu JieningYu deleted the enum-edcode-macro branch March 23, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JieningYu JieningYu JieningYu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0123456789-jpg @JieningYu