fix: remove extensive use of any type#215
Merged
RUKAYAT-CODER merged 1 commit intorinafcode:mainfrom Mar 25, 2026
Merged
Conversation
Close rinafcode#204 - Remove all `as any` casts in payments.service.ts (lines 117, 169, 276) - Remove `as any` cast in auth.service.ts (line 232) - Remove `any` parameter type in auth.service.ts generateTokens method - Create proper PaymentProvider, SubscriptionWebhookEvent, RefundWebhookData interfaces - Add InvoiceStatus enum to replace inline string union in invoice.entity.ts - Fix SubscriptionStatus enum usage (use SubscriptionStatus.ACTIVE instead of string cast) - Fix RefundStatus enum usage (use RefundStatus.PROCESSED instead of string cast) - Fix cancelAtPeriodEnd column type mismatch in subscription.entity.ts - Add proper return types to all service and controller methods - Type webhook service with proper Stripe/PayPal payload interfaces - Type controller request parameter with AuthenticatedRequest interface - Add isEmailVerified field to UpdateUserDto to eliminate cast - Remove duplicate SubscriptionInterval enum from DTO (reuse entity enum) - Fix JwtStrategy validate method typing and secretOrKey undefined - Fix transaction.service.ts strict mode errors (unknown error type) - Fix test/setup.ts global type declaration for strict mode - Add TransactionService mock to payments.service.spec.ts - Enable strict TypeScript configuration in tsconfig.json - Update DTOs to use Record<string, unknown> instead of Record<string, any>
|
@sublime247 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
@RUKAYAT-CODER please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #204
as anycasts in payments.service.ts (lines 117, 169, 276)as anycast in auth.service.ts (line 232)anyparameter type in auth.service.ts generateTokens method