Implement Advanced Search System#94
Merged
RUKAYAT-CODER merged 2 commits intorinafcode:mainfrom Mar 25, 2026
Merged
Conversation
…nterface Fix search system typing, dependency resolution, and UI-UX logical issues
|
@Josetic224 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Advanced Search System Refinement & Type Safety
Description
This PR addresses several critical technical and logical gaps in the new Advanced Search Interface. It focuses on resolving complex TypeScript assignability errors, stabilizing React hooks with functional updates, and ensuring consistent behavior between the UI and backend utilities.
🛠️ Core Changes
1. TypeScript & Type Safety Improvements
as SearchAnalytics[]) forlocalStoragedata to resolveunknown[]vsstring[]assignability issues.prev => ...), removing the need forhistoryandqueryin the dependency arrays of search callbacks.string[], preventing runtime errors in components calling.map().2. Dependency Resolution
npm install.3. Search Logic & UX Refinement
performSearchto trigger whenever any filter is applied (Difficulty, Type, or Topic), not just on text or topic changes.resultsCountanalytics payload to dynamically reflect real search mock data length instead of hardcoded values.useEffectforlocalStoragepersistence to keep the search history logic decoupled from state updates.🧪 Quality Assurance
npm run type-check(0 errors across searchUtils.ts, useAdvancedSearch.tsx, and associated UI components).localStoragesync persists search results between sessions.Closes #83