Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what request-header-size and response-header-size mean #440

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mikekap
Copy link

@mikekap mikekap commented May 4, 2021

Jetty's config options are for the PROTOCOL header, not a single Field: Value pair. So these options control the sum of all headers and status lines.

@atomist
Copy link

atomist bot commented May 4, 2021

Commit messages of this repository should follow the seven rules of a great Git commit message, as mentioned in the project's contributing guidelines. It looks like there's a few issues with the commit messages in this pull request:

  • The commit message subject is over 50 characters.
  • The commit message body has a line over 72 characters.

@weavejester
Copy link
Member

Do you have a source for that? I ask not to doubt, but so we have a record of why changes were made.

@mikekap
Copy link
Author

mikekap commented May 4, 2021

Unfortunately Jetty hasn't quite updated the docs, but this was the only source that I could find: jetty/jetty.project#6204 (comment) . The other way is to read through the code and notice that the length is used to allocate a buffer that includes the status line and all the headers.

Jetty's config options are for the PROTOCOL header, not a single
Field: Value pair. So these options control the sum of all headers
and status lines.
@weavejester
Copy link
Member

Thanks. From my reading of the link you provided, the sizes don't include the request/response line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants