Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unix domain socket support #511

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

agorgl
Copy link

@agorgl agorgl commented Sep 26, 2024

Similar to PR #478, although this now uses the new Unix Domain Socket Support in Jetty through jetty-unixdomain-server
https://webtide.com/unixdomain-support-in-jetty/

Usage of the new APIs is documented here:
https://jetty.org/docs/jetty/11/programming-guide/server/http.html#connector
https://jetty.org/docs/jetty/11/programming-guide/client/http.html#transport-unix-domain

@agorgl
Copy link
Author

agorgl commented Sep 26, 2024

Hmm, given that the unix domain sockets require at least java 16 (https://openjdk.org/jeps/380), should I update the pipeline to run the tests using java 17? I think (but i'm not sure) that this won't have any impact in runtime for the users that don't use the :unix-socket option

@weavejester
Copy link
Member

Thanks for the patch. I'd like to be sure that Jetty works over TCP for older versions of the JVM. Can you wrap the failing test in a conditional that checks the JVM version? Then we can potentially check with both.

@agorgl
Copy link
Author

agorgl commented Sep 26, 2024

Done! Please run the tests again

@weavejester
Copy link
Member

It looks good. Can you ensure that the lines in this patch are 80 characters or under?

Signed-off-by: Loukas Agorgianitis <[email protected]>
@agorgl
Copy link
Author

agorgl commented Sep 27, 2024

Fixed a slightly longer def line in the test file, everything else is below 80 chars except from the unix-domain-server-connector function definition that I kept it to 91 to match the format of the server-connector function.
I saw that this slight exception occurs in other places too like the binding of queue-max-capacity in create-threadpool function further down, in favor of consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants