Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve constructor mapping readability #1337

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aradalvand
Copy link

Fixes #1322

It's my first time contributing to a source generator project, so feel free to let me know if I've made any obvious mistakes.
Thanks.

Checklist

  • The existing code style is followed
  • The commit message follows our guidelines
  • Performed a self-review of my code
  • Hard-to-understand areas of my code are commented
  • The documentation is updated (as applicable)
  • Unit tests are added/updated
  • Integration tests are added/updated (as applicable, especially if feature/bug depends on roslyn or framework version in use)

@aradalvand aradalvand force-pushed the readable-constructor-mapping branch 2 times, most recently from 3758ce1 to 082be91 Compare June 14, 2024 11:46
Copy link
Contributor

@latonz latonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this contribution! Since this is your first contribution I need to manually approve each GH Actions run...

Looks pretty good already 😊👍 I added my feedback, feel free to discuss. There are also a few test failures which need to be fixed.

src/Riok.Mapperly/Emit/Syntax/SyntaxFactoryHelper.cs Outdated Show resolved Hide resolved
src/Riok.Mapperly/Emit/Syntax/SyntaxFactoryHelper.cs Outdated Show resolved Hide resolved
src/Riok.Mapperly/Emit/Syntax/SyntaxFactoryHelper.cs Outdated Show resolved Hide resolved
src/Riok.Mapperly/Emit/Syntax/SyntaxFactoryHelper.cs Outdated Show resolved Hide resolved
@aradalvand aradalvand force-pushed the readable-constructor-mapping branch from 90be032 to 2d67788 Compare June 22, 2024 10:47
Copy link
Contributor

@latonz latonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good now, thanks for the updates 😊

There are still some test and linter failures which need to be fixed before merging.
See also linter failures, test failures.

@aradalvand
Copy link
Author

@latonz Thanks! Sorry I've been very busy and couldn't get to fixing those, will do so this weekend when I hopefully get the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emit more readable constructor mapping code
2 participants