-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 90 #113
Fix issue 90 #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the dinfc R/W designation otherwise LGTM.
…permission is granted, remove pcc CSR
Co-authored-by: Alexander Richardson <[email protected]> Signed-off-by: Tariq Kurd <[email protected]>
a469f80
to
98cafd2
Compare
Co-authored-by: sorear <[email protected]> Signed-off-by: Tariq Kurd <[email protected]>
…emove references to PCC being a CSR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think that a Rocket-style debug ROM implementation will require D mode to always execute using the capability ISA, but that can be discussed as a separate issue.
We're no longer violating the debug spec's own rules on PC access, so approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small formatting change. Otherwise looks good to me.
Changes are: