Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 90 #113

Merged
merged 12 commits into from
Feb 20, 2024
Merged

Fix issue 90 #113

merged 12 commits into from
Feb 20, 2024

Conversation

tariqkurd-repo
Copy link
Collaborator

Changes are:

  1. pcc is no longer accessible as a CSR
  2. the pcc value is UNSPECIFIED in debug mode, and ASR permission is implicitly granted
  3. add dinfc CSR as a debug mode only source of infinity
  4. remove ASR permission from all debug mode CSRs as it's implicitly granted
  5. remove "M-mode" as a prerequisite for (e.g.) MTVECC as M-mode must always be present

Copy link
Collaborator

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the dinfc R/W designation otherwise LGTM.

@arichardson arichardson linked an issue Feb 16, 2024 that may be closed by this pull request
Copy link
Contributor

@sorear sorear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think that a Rocket-style debug ROM implementation will require D mode to always execute using the capability ISA, but that can be discussed as a separate issue.

We're no longer violating the debug spec's own rules on PC access, so approve.

Copy link
Collaborator

@andresag01 andresag01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small formatting change. Otherwise looks good to me.

@tariqkurd-repo tariqkurd-repo merged commit 00211d1 into riscv:main Feb 20, 2024
3 checks passed
@tariqkurd-repo tariqkurd-repo deleted the fix-issue-90 branch February 20, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prefer AUIPC over CSRR for debug pcc access
6 participants