Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IntelliJ editing plugin support #120

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

arichardson
Copy link
Collaborator

Move attribute definitions to a separate .adoc file, so that they
can be read by the IntelliJ plugin.
This makes it easier for me to edit the files and will not have
any functional changes. Opening this as a pull request to ensure
I don't conflict with anyone currently editing the asciidoc attributes.

Copy link
Collaborator

@andresag01 andresag01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. However, the build is getting a new warning (see here) and the title page of the PDF is not displaying the right logos. Could you please take a look? Thanks!
Screenshot from 2024-02-16 10-43-16

@arichardson
Copy link
Collaborator Author

Thanks for the changes. However, the build is getting a new warning (see here) and the title page of the PDF is not displaying the right logos. Could you please take a look? Thanks!

The new warning was already there, but I think it only shows up with --verbose. We seem to be embedding a NUL byte somewhere.

@tariqkurd-repo
Copy link
Collaborator

tariqkurd-repo commented Feb 19, 2024

Hi Alex - any idea why the first page isn't showing correctly in the built PDF, so the large RISC-V logo is missing?

@arichardson
Copy link
Collaborator Author

Looks like the missing image is due to the newline between the title and the include[] statement. Did not realize asciidoc was that whitespace sensitive.

This will make it possible to reuse this file in a follow-up commit.
Note: There is no whitespace between the header and the include since
having a newline there would break setting of the document attributes.
Copy link
Collaborator

@andresag01 andresag01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generated PDF has the expected layout, so I'll approve.

@tariqkurd-repo tariqkurd-repo merged commit a9ab6d6 into riscv:main Feb 21, 2024
3 checks passed
@arichardson arichardson deleted the intellij-support branch February 21, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants