-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IntelliJ editing plugin support #120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. However, the build is getting a new warning (see here) and the title page of the PDF is not displaying the right logos. Could you please take a look? Thanks!
The new warning was already there, but I think it only shows up with --verbose. We seem to be embedding a NUL byte somewhere. |
Hi Alex - any idea why the first page isn't showing correctly in the built PDF, so the large RISC-V logo is missing? |
Looks like the missing image is due to the newline between the title and the |
This will make it possible to reuse this file in a follow-up commit. Note: There is no whitespace between the header and the include since having a newline there would break setting of the document attributes.
This makes it easier to use IntelliJ IDEA to edit the source files. See https://intellij-asciidoc-plugin.ahus1.de/docs/users-guide/features/advanced/asciidoctorconfig-file
045f442
to
bbfa6a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generated PDF has the expected layout, so I'll approve.
Move attribute definitions to a separate .adoc file, so that they
can be read by the IntelliJ plugin.
This makes it easier for me to edit the files and will not have
any functional changes. Opening this as a pull request to ensure
I don't conflict with anyone currently editing the asciidoc attributes.