Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XLENMAX #123

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Remove XLENMAX #123

merged 2 commits into from
Apr 5, 2024

Conversation

sorear
Copy link
Contributor

@sorear sorear commented Feb 20, 2024

As of riscv/riscv-isa-manual@86ff22d6 MXLEN is read-only and reflects the widest XLEN of the machine, so use that instead.

As of riscv/riscv-isa-manual@0d7621d9 MXLEN >= SXLEN >= UXLEN is required by the base privileged architecture, so it does not need to be restated here.

Resolves #67.

Copy link
Collaborator

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me, will give others time to take a look and then merge it.

Only comment I have is whether we need to add a note that we assume privspec 1.13 with those changes as our baseline?

Copy link
Collaborator

@andresag01 andresag01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but do we need to wait for those changes in the RISC-V privileged spec to be formally released before merging this?

@arichardson
Copy link
Collaborator

It looks good, but do we need to wait for those changes in the RISC-V privileged spec to be formally released before merging this?

This PR explicitly references the privspec draft version, so I don't think we need to wait until it has been released (I assume that will happen before this spec is close to ratification).

sorear added 2 commits April 5, 2024 09:54
As of riscv/riscv-isa-manual@86ff22d6 MXLEN is read-only and reflects
the widest XLEN of the machine, so use that instead.

As of riscv/riscv-isa-manual@0d7621d9 MXLEN >= SXLEN >= UXLEN is
required by the base privileged architecture, so it does not need to be
restated here.

Resolves riscv#67.
This can be removed after 1.13 is ratified.
@andresag01
Copy link
Collaborator

@sorear : Thanks for your contribution! I rebased the PR and prepared it for merge since it was behind main.

@andresag01 andresag01 merged commit 4340db1 into riscv:main Apr 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove XLENMAX
3 participants