feat(V): add operation() for vmv.v.v and vmv.v.x#1764
Draft
adingank-qualcomm wants to merge 14 commits intoriscv:mainfrom
Draft
feat(V): add operation() for vmv.v.v and vmv.v.x#1764adingank-qualcomm wants to merge 14 commits intoriscv:mainfrom
adingank-qualcomm wants to merge 14 commits intoriscv:mainfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds a Claude skill that generates IDL operation() bodies for RISC-V instructions from their YAML spec files, writing to the spec if the operation() key is empty or to /tmp/<name>.yaml if already populated. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- model-instruction-from-spec: remove Sail references (being removed from UDB YAML files), add floating-point register access syntax - extract-instructions-from-subsection: soften exclusion list heading, drop "Two-letter" qualifier from register name exclusion rule Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Model the IDL operation() body for the vector integer move instructions: - vmv.v.v: copy vector register vs1 elements into vd - vmv.v.x: broadcast scalar integer register xs1 into all elements of vd Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
adingank-qualcomm
requested review from
ThinkOpenly and
dhower-qc
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1764 +/- ##
=======================================
Coverage 72.24% 72.24%
=======================================
Files 52 52
Lines 27671 27671
Branches 6009 6009
=======================================
Hits 19992 19992
Misses 7679 7679
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
operation()body forvmv.v.v: copies elements from vector registervs1intovdoperation()body forvmv.v.x: broadcasts scalar integer registerxs1into all elements ofvdBoth implementations follow the standard vector loop pattern: read vector state, compute
vlmax, iterate fromvstarttovl, write elements using bit-slice operations, and resetvstartto 0.Test plan
idlcvmv.v.xvstartis reset to 0 after the loop in both instructions🤖 Generated with Claude Code