Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

[bitmanip] Generate cmov under ZBT #273

Conversation

rdolbeau
Copy link

@rdolbeau rdolbeau commented Jun 6, 2021

Add basic support for cmov (ZBT), for [not]equal 0.

Signed-off-by: Romain Dolbeau [email protected]

@kito-cheng
Copy link
Collaborator

Thanks, it seems like missing testcase, but I can add it later.

@kito-cheng
Copy link
Collaborator

Let me run full gcc testsuite before merge.

@rdolbeau
Copy link
Author

rdolbeau commented Jun 7, 2021

@kito-cheng I added a test case for cmov.

long cmov2(long s, long b, long c) {
return (s == 0 ? b : c);
}
#endif
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All using long is fine :)

@kito-cheng
Copy link
Collaborator

@rdolbeau let you know, I'll verify this PR and #265 today, and then #267 later, thanks you :)

@rdolbeau rdolbeau force-pushed the riscv-gcc-10.2.0-rvb-cmov branch from 3a37d03 to 3af2ee4 Compare June 7, 2021 06:45
@rdolbeau
Copy link
Author

rdolbeau commented Jun 7, 2021

@kito-cheng Of course you're right, long is fine. Fixed this and #265

@rdolbeau
Copy link
Author

rdolbeau commented Jun 7, 2021

@rdolbeau let you know, I'll verify this PR and #265 today, and then #267 later, thanks you :)

#267 isn't ready yet unfortunately; there's [at least] one bug I'm not able to figure out :-(

Signed-off-by: Romain Dolbeau <[email protected]>
@rdolbeau rdolbeau force-pushed the riscv-gcc-10.2.0-rvb-cmov branch from 3af2ee4 to 8a0387e Compare June 7, 2021 06:59
@kito-cheng kito-cheng merged commit e6ccabf into riscvarchive:riscv-gcc-10.2.0-rvb Jun 7, 2021
@rdolbeau rdolbeau deleted the riscv-gcc-10.2.0-rvb-cmov branch June 7, 2021 08:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants