Skip to content

extrenal data sources & client - #2

Closed
rish664 wants to merge 4 commits into
rish664:mainfrom
rish231294:datasource
Closed

extrenal data sources & client#2
rish664 wants to merge 4 commits into
rish664:mainfrom
rish231294:datasource

Conversation

@rish664

@rish664 rish664 commented Mar 18, 2026

Copy link
Copy Markdown
Owner

Description

[Provide a brief description of the changes in this PR]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Is there an addition/change in API Request, Response? If yes, documentation is required)
  • Performance improvement
  • Code refactoring
  • Security fix

Related Issues

  • Fixes #[issue number]
  • Closes #[issue number]
  • Related to #[issue number]

How Has This Been Tested?

[Describe the tests you ran to verify your changes. Provide instructions so we can reproduce.]

Test Configuration

  • Unit tests pass
  • Integration tests pass
  • Manual testing completed
  • Cross-browser testing (if applicable)
  • Mobile responsiveness tested (if applicable)

Core Functionality Testing

Please confirm that the following core functionalities are working as expected:

  • Search capabilities are working correctly
  • Knowledge search is functioning properly
  • Connector indexing is working as expected
  • Citations are displaying and linking correctly
  • Documentation is updated at https://docs.pipeshub.com/introduction

What You Have Tested

Please describe what you have specifically tested:

  • Feature works in development environment
  • Feature works in staging environment
  • Error handling scenarios tested
  • Edge cases considered and tested
  • Performance impact assessed
  • Security implications reviewed

Test Results

[Provide details of your test results here]

Screenshots/Videos

Before:
[Attach screenshots/videos showing the current behavior]

After:
[Attach screenshots/videos showing the new behavior]

Note: Screenshots are required before merge for UI changes.

Code Quality Checklist

  • My code follows the project's coding standards
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Documentation

  • Documentation has been updated (if applicable)
  • API documentation updated (if applicable)
  • README updated (if applicable)
  • Changelog updated (if applicable)

Security Considerations

  • No sensitive data is exposed
  • Input validation is implemented where necessary
  • Authentication/authorization is properly handled
  • No security vulnerabilities introduced

Breaking Changes

  • This PR introduces breaking changes
  • Migration guide provided (if applicable)
  • Version bump required

If breaking changes are introduced, please describe them here:

[Describe any breaking changes and how users should adapt]

Performance Impact

  • No performance impact
  • Performance improved
  • Performance impact assessed and acceptable

[Describe any performance implications]

Dependencies

  • No new dependencies added
  • New dependencies are necessary and approved
  • Dependencies updated and tested

List any new dependencies:

  • [Dependency name and version]

Deployment Notes

[Any special deployment considerations or steps]

Checklist Before Merge

  • All tests are passing
  • Code review completed and approved
  • Documentation updated and reviewed
  • Screenshots/videos attached for UI changes
  • Core functionality verified
  • Security review completed (if applicable)
  • Performance impact assessed
  • Ready for production deployment

Additional Notes

[Any additional information that would be helpful for reviewers]


For Reviewers:

Please ensure all checklist items are completed before approving this PR. Pay special attention to:

  • Core functionality testing
  • Security implications
  • Performance impact
  • Documentation completeness



if __name__ == "__main__":
print(generate_datasource())

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

This expression logs [sensitive data (password)](1) as clear text. This expression logs [sensitive data (password)](2) as clear text.
code = generate_datasource()
output_path = __file__.replace("run_generator.py", "lumapps.py")
with open(output_path, "w") as f:
f.write(code)

Check failure

Code scanning / CodeQL

Clear-text storage of sensitive information

This expression stores [sensitive data (password)](1) as clear text. This expression stores [sensitive data (password)](2) as clear text.
print(f"\nMethods by Resource:")
for category, count in resource_categories.items():
if count > 0:
print(f" - {category}: {count}")

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

This expression logs [sensitive data (private)](1) as clear text. This expression logs [sensitive data (private)](1) as clear text. This expression logs [sensitive data (private)](2) as clear text. This expression logs [sensitive data (private)](2) as clear text. This expression logs [sensitive data (private)](1) as clear text.
@rish664 rish664 closed this Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants