Conversation
xxchan
force-pushed
the
xxchan/latest-nightly-rust
branch
from
e9e77c9 to
019e03c
Compare
xxchan
force-pushed
the
xxchan/latest-nightly-rust
branch
2 times, most recently
from
41eb5fb to
cc89f14
Compare
Signed-off-by: xxchan <xxchan22f@gmail.com>
Signed-off-by: xxchan <xxchan22f@gmail.com>
Signed-off-by: xxchan <xxchan22f@gmail.com>
Signed-off-by: xxchan <xxchan22f@gmail.com>
xxchan
force-pushed
the
xxchan/latest-nightly-rust
branch
from
cc89f14 to
1906cb5
Compare
Signed-off-by: xxchan <xxchan22f@gmail.com>
Signed-off-by: xxchan <xxchan22f@gmail.com>
|
The deno's illegal instruction issue still persists :) |
rust-lang/rust#113169 Signed-off-by: xxchan <xxchan22f@gmail.com>
xxchan
force-pushed
the
xxchan/latest-nightly-rust
branch
from
1906cb5 to
1b95f15
Compare
github-actions
bot
added
type/build
|
Unblocked since deno is removed in #17875 |
Signed-off-by: xxchan <xxchan22f@gmail.com>
Signed-off-by: xxchan <xxchan22f@gmail.com>
format_args: rust-lang/rust-clippy#12567 Signed-off-by: xxchan <xxchan22f@gmail.com>
|
sim build ICE due to rust-lang/rust#127030 |
Signed-off-by: xxchan <xxchan22f@gmail.com>
xxchan
force-pushed
the
xxchan/latest-nightly-rust
branch
from
f31821a to
10221be
Compare
Signed-off-by: xxchan <xxchan22f@gmail.com>
Signed-off-by: xxchan <xxchan22f@gmail.com>
| } | ||
|
|
||
| pub type KafkaSinkDeliveryFuture = impl TryFuture<Ok = (), Error = SinkError> + Unpin + 'static; | ||
| mod opaque_type { |
There was a problem hiding this comment.
Is this still necessary as we won't bump to > 2024-06-12?
There was a problem hiding this comment.
Not necessary, but I think it doesn't hurt.
| #![expect( | ||
| unexpected_cfgs, | ||
| reason = "feature(hdfs-backend) is banned https://github.com/risingwavelabs/risingwave/pull/7875" | ||
| )] | ||
|
|
There was a problem hiding this comment.
Will this cause the whole object/mod.rs to be excluded from the build?
There was a problem hiding this comment.
👀 what do you mean? It only configures lint here
There was a problem hiding this comment.
For some reason, vscode warns me that the code in this file is not active. That is why I am wondering whether the file is excluded.
There was a problem hiding this comment.
Seems a RA bug and already fixed.
rust-lang/rust-analyzer#17817
3 participants
Signed-off-by: xxchan xxchan22f@gmail.comI hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
2024-06-12. There's a large change on TAIT: Tait must be constrained if in sig rust-lang/rust#113169 TAIT feature is broken rust-lang/rust#126387, basically we will now have to define opaque types in its own module. (I've fixed some, but there are too many) In the future, there will be a#[defines]macro to ease this issue.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.