feat: update iceberg version #19963
Merged
feat: update iceberg version #19963
+74
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZENOTME
force-pushed
the
zj/update_iceberg
branch
from
e68a472 to
381464f
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Cargo.toml
Outdated
Comment on lines
156
to
158
| iceberg = { git = "https://github.com/risingwavelabs/iceberg-rust.git", rev = "667c173d4c1d8fed2f4ef046ffa0c80a6ecec6ef" } | ||
| iceberg-catalog-rest = { git = "https://github.com/risingwavelabs/iceberg-rust.git", rev = "667c173d4c1d8fed2f4ef046ffa0c80a6ecec6ef" } | ||
| iceberg-catalog-glue = { git = "https://github.com/risingwavelabs/iceberg-rust.git", rev = "667c173d4c1d8fed2f4ef046ffa0c80a6ecec6ef" } |
There was a problem hiding this comment.
The revision hashes for the iceberg dependencies are mismatched between Cargo.toml (667c173) and Cargo.lock (781f518). This discrepancy should be resolved to ensure deterministic builds. Consider updating Cargo.toml to match the revision in Cargo.lock, or regenerate Cargo.lock with cargo update if 667c173 is the intended version.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
ZENOTME
force-pushed
the
zj/update_iceberg
branch
4 times, most recently
from
5dc94f1 to
b015f60
Compare
xxchan
approved these changes
Dec 31, 2024
xxchan
reviewed
Dec 31, 2024
ZENOTME
force-pushed
the
zj/update_iceberg
branch
from
b015f60 to
fa4da70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
Documentation
Release note