Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): purification for source def sql #19965

Open
wants to merge 3 commits into
base: bz/purify-sql-part-1
Choose a base branch
from

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Dec 30, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Sequel to #19949. Extract the purification snippet to reuse for CREATE SOURCE.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Copy link
Member Author

BugenZhao commented Dec 30, 2024

@BugenZhao BugenZhao force-pushed the bz/purify-sql-part-1 branch from 7922a7b to 7fd1ad9 Compare December 31, 2024 07:40
@BugenZhao BugenZhao force-pushed the bz/purify-sql-part-2 branch 2 times, most recently from 4aa5362 to 4cf01e5 Compare December 31, 2024 08:47
@BugenZhao BugenZhao marked this pull request as ready for review January 2, 2025 07:53
@BugenZhao BugenZhao requested review from StrikeW and xxchan January 2, 2025 07:53
@BugenZhao BugenZhao force-pushed the bz/purify-sql-part-1 branch from 2869377 to 5a21eb2 Compare January 3, 2025 03:29
@BugenZhao BugenZhao force-pushed the bz/purify-sql-part-2 branch from 274a032 to ec38b32 Compare January 3, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants