Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): use ephemeral env for python inline scripts by uv if available #19971

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

BugenZhao
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

If uv is installed in the system, create an ephemeral env and run python scripts for inline tests within it. This allows for a zero-configuration experience.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@BugenZhao BugenZhao requested review from stdrc and xxchan December 31, 2024 07:16
@graphite-app graphite-app bot requested a review from a team December 31, 2024 07:17
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

Copy link
Member

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You really niubi le

@BugenZhao BugenZhao enabled auto-merge January 2, 2025 06:07
@BugenZhao BugenZhao disabled auto-merge January 2, 2025 06:11
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao force-pushed the bz/inline-test-python-wrapper branch from 2eedf15 to aa72b9c Compare January 2, 2025 06:13
@BugenZhao BugenZhao added this pull request to the merge queue Jan 2, 2025
Merged via the queue into main with commit 0e61581 Jan 2, 2025
9 of 10 checks passed
@BugenZhao BugenZhao deleted the bz/inline-test-python-wrapper branch January 2, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants