feat(connector): introduce gcs file scan #19974
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| pub schema: Schema, | ||
| pub file_format: FileFormat, | ||
| pub storage_type: StorageType, | ||
| pub creditial: String, |
There was a problem hiding this comment.
The variable creditial appears to be misspelled - it should be credential to maintain consistency with the protobuf definition and other usages throughout the codebase.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has checked 5533 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 2332 | 1 | 3200 | 0 |
Click to see the invalid file list
- src/batch/executors/src/executor/gcs_file_scan.rs
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
…nto wcy/gcs_file_scan.pr
chenzl25
reviewed
Jan 2, 2025
Comment on lines
+111
to
+112
| string credential = 3; | ||
| string service_account = 4; |
There was a problem hiding this comment.
Why we need 2 fields here stand for? IIRC, we only need a service account json encoded by base64.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Support table function file_scan from gcs bucket, the syntax is
file_scan(parquet, gcs, credential, service_account, file_loaction). The same with s3 file_scan, it also supports reading a single parquet file or all parquet files in a directory.Implementation detail:
Checklist
Documentation
Pls add this feature in documentation,
file_scan(parquet, gcs, credential, service_account, file_loaction).Release note