Skip to content

chore(rustfmt): format Cargo.toml#9410

Closed
xxchan wants to merge 1 commit intomainfrom
xxchan/fmt
Closed

chore(rustfmt): format Cargo.toml#9410
xxchan wants to merge 1 commit intomainfrom
xxchan/fmt

Conversation

@xxchan
Copy link
Contributor

@xxchan xxchan commented Apr 24, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Draft. There seems to be some minor problems to be fixed.

similar to #9409

test rust-lang/rustfmt#5240

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Copy link
Contributor

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about https://taplo.tamasfe.dev/? It's used by Even Better TOML, a VS Code extension. I've used this ext for a long time and it formats well.

edition = "2021"
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this line can be removed.

@xxchan
Copy link
Contributor Author

xxchan commented May 8, 2023 via email

@github-actions
Copy link
Contributor

This PR has been open for 60 days with no activity. Could you please update the status? Feel free to ping a reviewer if you are waiting for review.

@xxchan xxchan closed this Jul 23, 2023
@xxchan xxchan deleted the xxchan/fmt branch April 18, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments