Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop tab glt positioning #3512

Merged

Conversation

paul-bayleaf
Copy link
Contributor

As per E-laute project implements positioning for German lute tablature using loc and valign. Implements notationsubtype for different variants of the 6th course - although there is much more to do here. Fix due to change in GetListSize interface. Fix to use explicit strikethrough of digit one for open 6th course etc instead of SMUFL_E595_ornamentLeftVerticalStrokeWithCross.

@paul-bayleaf
Copy link
Contributor Author

Fixes Issue #3473

@lpugin
Copy link
Contributor

lpugin commented Sep 8, 2023

Thanks. Do we have a corresponding PR that has been made (and merged?) to the tablature-ig customization? We need to make sure the what comes into Verovio is in sync with that. Pinging @reinierdevalk @musicog @DILewis

@paul-bayleaf
Copy link
Contributor Author

Thanks.

I've updated my pull request for the MEI 4.0.1 schema customizations for the German lute tablature work. I note that it also works for MEI 5.0. I use it to verify the MEI output of my luteconv program.
music-encoding/tablature-ig#26
But this has not been merged.

If you are referring to
https://github.com/music-encoding/music-encoding/tree/tablature-ig
then that was last updated on 2021-11-16. I've not touched this.

@lpugin
Copy link
Contributor

lpugin commented Sep 11, 2023

Great, thanks. @reinierdevalk or @DILewis: could you look at updating the tag to MEI 5.0 ?

@lpugin
Copy link
Contributor

lpugin commented Sep 13, 2023

I have now updated https://github.com/music-encoding/music-encoding/tree/tablature-ig and brought it inline with https://github.com/music-encoding/music-encoding/tree/develop.

The proposed changed should be added there. The two modifications adding att.verticalAlign to note and staffDef should be brought up for discussion since these are not tablature-specific elements.

src/note.cpp Outdated Show resolved Hide resolved
@lpugin lpugin merged commit df82a54 into rism-digital:develop-tab Jan 24, 2024
4 checks passed
@paul-bayleaf paul-bayleaf deleted the develop-tab-GLT-positioning branch January 24, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants