More metadata fixes #3555
Merged
More metadata fixes #3555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… beginning of the date part, and put the overall date qualifier at the end.
…ll which of the several works described is the one encoded in the <music> element.
…26/-1594/2/2, where the range starts at 1525-1526, and ends at 1594/02/02).
…mplex date ranges require a DateConstruct pair (instead of a DateWithErrors pair).
|
@lpugin please review my iomei.cpp/doc.h changes. @craigsapp please review the iohumdrum.{h, cpp} changes. |
… be an EDTF selection with a range, not an EDTF range ("[1594..1595]" not "1594/1595").
|
One last change to emitted EDTF (in MADS data) from a review by Perry. |
|
Could you post a sample Humdrum and MEI file? Thanks |
lpugin
requested changes
Dec 8, 2023
|
Here is an example Humdrum file and the resulting output.mei file (both with .txt extensions, so GitHub will take them). |
lpugin
approved these changes
Dec 11, 2023
Merged
craigsapp
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biggest change is a reworking of Humdrum date parsing to handle complex date ranges such as "!!!CDT:1750^1751-~1802/6" (which means composer birthdate is between 1750 and 1751, and composer death date is approximately June 1802). Several other fixes as well. Verovio and converter21 now produce exactly the same MEI metadata when converting Humdrum to MEI (tested on a few thousand Humdrum scores from various organizations).
I believe my Humdrum to MEI metadata work is now complete.