Compare changes between practicalmeteor and rissem mocha-core #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run functions with mocha suite context
Fix pending tests without callback
Owner
|
Overall, this looks good. Docs and the wrapping code are both definitely clearer. I question not including server side mocha though. Can we just point to the latest version, and expect this package to track the latest mocha version? |
Author
|
@rissem we still include server side mocha in https://github.com/practicalmeteor/meteor-mocha. We want the core to not depend on any mocha version, and just update the mocha version in the package people will actually use. Our https://github.com/practicalmeteor/meteor-mocha is a fork of the real mocha with some client side reporter modifications. Related to that, if we'll be able to use the browserified version of mocha server side too, we'll also improve build times, I think. |
Refactor and cleanup fibers code
Apply review changes
Version 1.0.0 - common mocha core for practicalmeteor and dispatch packages
…brower to undefined. Fixes #8 and praticalmeteor/mocha#51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.