Merge pull request #176 from rit-sse/remove-async-useeffect

Removed Async UseEffect causing build warnings
rit-sse · Sep 29, 2024 · 6c0461b · 6c0461b
2 parents e2aaae0 + d9a1386
commit 6c0461b
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 15 deletions.
diff --git a/next/app/go/GoLink.tsx b/next/app/go/GoLink.tsx
@@ -282,9 +282,11 @@ const EditAndDelete: React.FC<GoLinkProps> = ({
   const { data: session } = useSession();
   const [isOfficer, setIsOfficer] = useState(false);
 
-  useEffectAsync(async () => {
-    const data = await fetchAuthLevel();
-    setIsOfficer(data.isOfficer);
+  useEffect(() => {
+    (async () => {
+      const data = await fetchAuthLevel();
+      setIsOfficer(data.isOfficer);
+    })();
   }, []);
 
   if (isOfficer) {

diff --git a/next/app/go/MakeNewGoLink.tsx b/next/app/go/MakeNewGoLink.tsx
@@ -1,5 +1,5 @@
 import { useSession } from "next-auth/react";
-import { useCallback, useEffect, useState } from "react";
+import { use, useCallback, useEffect, useState } from "react";
 import { CreateGoLinkProps } from "./page";
 import { useEffectAsync } from "@/lib/utils";
 import { goLinksApi, fetchAuthLevel } from "@/lib/api";
@@ -44,10 +44,13 @@ export const GoLinkButton: React.FC<CreateGoLinkProps> = ({ fetchData }) => {
   };
 
   const [isOfficer, setIsOfficer] = useState(false);
-  useEffectAsync(async () => {
-    const data = await fetchAuthLevel();
-    console.log(data);
-    setIsOfficer(data.isOfficer);
+
+  useEffect(() => {
+    (async () => {
+      const data = await fetchAuthLevel();
+      console.log(data);
+      setIsOfficer(data.isOfficer);
+    })
   }, []);
 
   if (isOfficer) {

diff --git a/next/lib/utils.ts b/next/lib/utils.ts
@@ -11,10 +11,4 @@ export const isUrlValid = (str: string) => {
     "i"
   );
   return pattern.test(str);
-};
-
-export const useEffectAsync = (func: () => any, deps: any[]) => {
-  return useEffect(() => {
-    func();
-  }, deps);
-};
+};