Skip to content

fix(frontend): add Full Name and Work Email validation in ContactSales Get Started form #4035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aryanbansal-05 wants to merge 1 commit into
base: gssoc
Choose a base branch
from
Open

fix(frontend): add Full Name and Work Email validation in ContactSales Get Started form #4035

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 33 additions & 2 deletions Frontend/src/pages/ContactSales.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ export default function ContactSales() {
const navigate = useNavigate();
const [isSubmitting, setIsSubmitting] = useState(false);
const [isSuccess, setIsSuccess] = useState(false);
const [errors, setErrors] = useState({});
const [formData, setFormData] = useState(() => {
// Validate the stored company_size against known valid options
const stored = safeGetItem(LS_KEY);
Expand All @@ -65,10 +66,38 @@ export default function ContactSales() {
if (name === 'company_size') {
safeSetItem(LS_KEY, value);
}
// Clear error on change
if (errors[name]) {
setErrors(prev => ({ ...prev, [name]: '' }));
}
};

const validateForm = () => {
const newErrors = {};

// Full Name: letters, spaces, hyphens, apostrophes only
const nameRegex = /^[a-zA-Z\s'\-]{2,100}$/;
if (!formData.name.trim()) {
newErrors.name = 'Full name is required.';
} else if (!nameRegex.test(formData.name.trim())) {
newErrors.name = 'Full name must contain only letters, spaces, hyphens, or apostrophes.';
}

// Work Email: must have valid domain with TLD (e.g. abc@company.com)
const emailRegex = /^[^\s@]+@[^\s@]+\.[^\s@]{2,}$/;
if (!formData.email.trim()) {
newErrors.email = 'Work email is required.';
} else if (!emailRegex.test(formData.email.trim())) {
newErrors.email = 'Please enter a valid work email address (e.g. john@company.com).';
}

setErrors(newErrors);
return Object.keys(newErrors).length === 0;
};

const handleSubmit = async (e) => {
e.preventDefault();
if (!validateForm()) return;
setIsSubmitting(true);

try {
Expand Down Expand Up @@ -197,12 +226,13 @@ export default function ContactSales() {
type="text"
required
name="name"
className="w-full pl-11 pr-4 py-3 bg-white border border-gray-200 rounded-xl focus:ring-2 focus:ring-emerald-500 focus:border-emerald-500 transition-all font-medium text-gray-900"
className={`w-full pl-11 pr-4 py-3 bg-white border rounded-xl focus:ring-2 focus:ring-emerald-500 focus:border-emerald-500 transition-all font-medium text-gray-900 ${errors.name ? 'border-red-400' : 'border-gray-200'}`}
placeholder="John Doe"
value={formData.name}
onChange={handleChange}
/>
</div>
{errors.name && <p className="text-red-500 text-xs mt-1 ml-1">{errors.name}</p>}
</div>

<div className="space-y-1.5">
Expand All @@ -215,12 +245,13 @@ export default function ContactSales() {
type="email"
required
name="email"
className="w-full pl-11 pr-4 py-3 bg-white border border-gray-200 rounded-xl focus:ring-2 focus:ring-emerald-500 focus:border-emerald-500 transition-all font-medium text-gray-900"
className={`w-full pl-11 pr-4 py-3 bg-white border rounded-xl focus:ring-2 focus:ring-emerald-500 focus:border-emerald-500 transition-all font-medium text-gray-900 ${errors.email ? 'border-red-400' : 'border-gray-200'}`}
placeholder="john@company.com"
value={formData.email}
onChange={handleChange}
/>
</div>
{errors.email && <p className="text-red-500 text-xs mt-1 ml-1">{errors.email}</p>}
</div>
</div>

Expand Down
Loading