Fix/country field validation - #4038
Open
Nancy-3012 wants to merge 3333 commits into
Open
Conversation
…nflict-free)
- Split test_agent_scorecard.py into two files (was concatenated) - Fix unclosed string literal in test_pii_redactor.py - Fix E701 multi-statement if/elif lines in test_auto_close_service.py - Fix E701 for-loop one-liners in test_duplicate_cache_limit.py - Fix E701 sys.modules stubs in test_supabase_service.py - Fix E701 sys.modules stubs in test_tenant_isolation.py - Fix special characters in docstrings (>= replaces unicode >=) - Add missing get_encryption_key() to encryption.py - Fix test_translation_service.py import ordering - Update pytest.ini norecursedirs to exclude .tmp-ci-venv :wq#
…nflict-free)
…nflict-free)
…wn selector in ContactSales form
|
@Nancy-3012 is attempting to deploy a commit to the ritesh Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedToo many files! This PR contains 2983 files, which is 2883 over the limit of 100. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (17)
📒 Files selected for processing (2983)
You can disable this status message by setting the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Summary
Resolves #4034 by adding a Country field to the ContactSales form as a predefined dropdown selector, preventing arbitrary text values like
abc123A!1from being entered.🛠️ Changes Made
Frontend/src/pages/ContactSales.tsxAdded
countryfield toformDatastate:Added Country dropdown field in the form:
<select>dropdown — no free text input allowedSelect your country...✅ Fixes
abc123A!1can no longer be entered — free text input replaced with dropdownCloses #4034