fix: s1/s2 supply results not updating correctly

rithask · May 14, 2024 · 7940a9b · 7940a9b
1 parent 5739e30
commit 7940a9b
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/backend/utils/helper.js b/backend/utils/helper.js
@@ -99,7 +99,10 @@ const cleanSupplyData = (newData, oldData) => {
   }
 
   oldData.semesters.forEach(oldSemester => {
-    if (oldSemester.semester === newSemesterDetails.semester) {
+    if (oldSemester.semester === newSemesterDetails.semester
+      || ((oldSemester.semester === "S1" || oldSemester.semester === "S2")
+        && (newSemesterDetails.semester === "S1" || newSemesterDetails.semester === "S2"))
+    ) {
       newResults.forEach(newResult => {
         oldSemester.results.forEach(oldResult => {
           if (oldResult.course === newResult.course) {