Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deprecation messages #162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve deprecation messages #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/comeonin.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,14 @@ defmodule Comeonin do
@behaviour Comeonin.PasswordHash

@impl Comeonin
@deprecated "This function will be removed in the next major version."
@deprecated "Use hash_pwd_salt(password, opts) to generate a new hash and set it on the password_hash field"
def add_hash(password, opts \\ []) do
hash_key = opts[:hash_key] || :password_hash
%{hash_key => hash_pwd_salt(password, opts)}
end

@impl Comeonin
@deprecated "This function will be removed in the next major version."
@deprecated "Use verify_pass(password, hash) instead, where hash is typically the value of the stored hash, such as user.password_hash"
def check_pass(user, password, opts \\ [])

def check_pass(nil, _password, opts) do
Expand Down