This repository was archived by the owner on Oct 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 44
feat: update rust to 0.9.0 #984
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
72
to
75
| let mut options = GetOrCreateOptions { | ||
| tags: Some(tags), | ||
| ..Default::default() | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GetOrCreateOptions struct has been refactored in this update and no longer contains a tags field. This example needs to be updated to use the new API structure, which now uses key instead of tags. The correct approach would be:
let key = vec![
"general".to_string(),
];
let options = GetOrCreateOptions::default();
let room = client.get_or_create("chatRoom", key, options)?
.connect();This matches the updated client API signature shown elsewhere in the changes.
Suggested change
| let mut options = GetOrCreateOptions { | |
| tags: Some(tags), | |
| ..Default::default() | |
| }; | |
| let key = vec![ | |
| "general".to_string(), | |
| ]; | |
| let options = GetOrCreateOptions::default(); | |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
9e4ec66 to
7ca9225
Compare
This was referenced Jun 19, 2025
Closed
Closed
This was referenced Jun 19, 2025
Closed
Closed
749fb1f to
af5e352
Compare
7ca9225 to
49f1a8b
Compare
This was referenced Jun 26, 2025
749fb1f to
af5e352
Compare
7ca9225 to
49f1a8b
Compare
Draft
49f1a8b to
7ca9225
Compare
af5e352 to
749fb1f
Compare
This was referenced Jun 27, 2025
Closed
Merge activity
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

No description provided.