feat(users): user wf tests #1935

abcxff · 2025-01-22T21:09:53Z

Changes

abcxff · 2025-01-22T21:10:19Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

cloudflare-workers-and-pages · 2025-01-22T21:11:23Z

Deploying rivet with Cloudflare Pages

Latest commit:	`0964bef`
Status:	✅ Deploy successful!
Preview URL:	https://6426e848.rivet.pages.dev
Branch Preview URL:	https://01-22-feat-users-user-wf-tes.rivet.pages.dev

View logs

greptile-apps

PR Summary

This PR introduces a new faker package for generating test data in the Rivet codebase, focusing on user workflow testing. Here's a concise summary of the key changes:

Added new faker service package in /packages/services/faker for generating test data with user operations
Implemented user workflow tests using the new faker operations for consistent test data generation
Modified existing user tests to use ctx.op(faker::ops::user::Input {}) instead of op!([ctx] faker_user {})
Added user registry to workflow worker setup for proper workflow integration
Updated monolith-workflow-worker to include user workspace dependency

The changes improve test consistency and provide better infrastructure for user-related testing across the codebase.

_{20 file(s) reviewed, 4 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

packages/services/faker/tests/user.rs

packages/services/faker/src/ops/user.rs

packages/services/user/Cargo.toml

packages/services/user/tests/profile_validate.rs

NathanFlurry

remove unneeded use of compat in faker

abcxff · 2025-02-14T22:36:30Z

@greptileai

greptile-apps

PR Summary

Based on the provided context, I'll focus on the most recent changes that haven't been covered in previous reviews:

This PR continues the implementation of user workflow testing with the following key updates:

Added workflow test in /packages/services/faker/tests/user.rs to verify basic user creation functionality
Implemented user workflow registration in /packages/services/user/src/lib.rs for proper workflow integration
Enhanced user workflow module in /packages/services/user/src/workflows/user/mod.rs with improved logging and activity tracking
Added helper functions for generating display names and IDs with proper randomization

The changes demonstrate a focus on improving test infrastructure and workflow management for user-related operations.

_{20 file(s) reviewed, 5 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-02-14T22:37:08Z

packages/services/faker/src/ops/mod.rs

@@ -0,0 +1 @@
+pub mod user;


style: ensure user module is properly documented with rustdoc comments explaining its purpose and usage

greptile-apps · 2025-02-14T22:37:25Z

packages/services/faker/Cargo.toml

+[dependencies]
+chirp-workflow.workspace = true
+user.workspace = true


style: Dependencies look correct based on usage in tests, but consider adding util/faker as a dependency since it's used in the user tests (e.g. util::faker::email())

greptile-apps · 2025-02-14T22:37:43Z

packages/services/faker/tests/user.rs

+use chirp_workflow::prelude::*;
+
+#[workflow_test]
+async fn empty(ctx: TestCtx) {


style: function name 'empty' is not descriptive of what the test actually does

greptile-apps · 2025-02-14T22:37:52Z

packages/services/faker/src/ops/user.rs

+    // TODO: Remove compat once ctx.workflow, ctx.subscribe exist on OpCtx
+    let mut creation_sub = chirp_workflow::compat::subscribe::<
+        user::workflows::user::CreateComplete, _
+    >(&ctx.op_ctx(), ("user_id", user_id)).await?;


logic: subscription is created before workflow dispatch but not cleaned up if workflow dispatch fails. Consider using a try-finally pattern or RAII to ensure subscription cleanup.

greptile-apps · 2025-02-14T22:37:52Z

packages/services/faker/src/ops/user.rs

+	.dispatch()
+	.await?;
+
+    creation_sub.next().await?;


style: no timeout on creation_sub.next() could potentially hang indefinitely if workflow fails silently

This was referenced Jan 22, 2025

chore(services/user): migrate user-team-list proto op #1650

Closed

chore(users): migrate proto backend to native #1805

Closed

chore(users/workflow): setup basic e2e user workflow #1844

Closed

abcxff mentioned this pull request Jan 22, 2025

feat(user/workflows): profile set signal #1902

Closed

abcxff force-pushed the 01-22-feat_user_workflows_profile_set_signal branch from c562f66 to 7c0e8aa Compare January 22, 2025 21:11

abcxff force-pushed the 01-22-feat_users_user_wf_tests branch from 0faf1d5 to eef480c Compare January 22, 2025 21:11

abcxff force-pushed the 01-22-feat_user_workflows_profile_set_signal branch from 7c0e8aa to c70fe90 Compare January 22, 2025 22:19

abcxff force-pushed the 01-22-feat_users_user_wf_tests branch 2 times, most recently from 883775d to 49cc103 Compare January 22, 2025 22:42

abcxff force-pushed the 01-22-feat_user_workflows_profile_set_signal branch from c70fe90 to e62fbcd Compare January 28, 2025 18:50

abcxff force-pushed the 01-22-feat_users_user_wf_tests branch from 49cc103 to c7df546 Compare January 28, 2025 18:50

abcxff force-pushed the 01-22-feat_user_workflows_profile_set_signal branch from e62fbcd to f129825 Compare January 28, 2025 19:50

abcxff force-pushed the 01-22-feat_users_user_wf_tests branch from c7df546 to ba97929 Compare January 28, 2025 19:51

abcxff mentioned this pull request Jan 28, 2025

feat(user): migrate pub/sub #1953

Closed

abcxff force-pushed the 01-22-feat_user_workflows_profile_set_signal branch from f129825 to af1c2e9 Compare January 28, 2025 19:59

abcxff force-pushed the 01-22-feat_users_user_wf_tests branch from ba97929 to 8ed4f56 Compare January 28, 2025 19:59

abcxff force-pushed the 01-22-feat_user_workflows_profile_set_signal branch from af1c2e9 to 1854f2f Compare January 28, 2025 22:35

abcxff force-pushed the 01-22-feat_users_user_wf_tests branch 3 times, most recently from 1215ed1 to 6d9b376 Compare January 29, 2025 03:04

abcxff mentioned this pull request Jan 29, 2025

chore(users): delete old worker code #1959

Closed

abcxff force-pushed the 01-22-feat_user_workflows_profile_set_signal branch from 1854f2f to 65dbb93 Compare February 6, 2025 21:51

abcxff force-pushed the 01-22-feat_users_user_wf_tests branch from 6d9b376 to 9277340 Compare February 6, 2025 21:51

abcxff force-pushed the 01-22-feat_user_workflows_profile_set_signal branch from 65dbb93 to d1e1fb6 Compare February 6, 2025 21:57

abcxff force-pushed the 01-22-feat_users_user_wf_tests branch from 9277340 to cfaabb0 Compare February 6, 2025 21:57

abcxff marked this pull request as ready for review February 10, 2025 19:38

greptile-apps bot reviewed Feb 10, 2025

View reviewed changes

packages/services/faker/tests/user.rs Show resolved Hide resolved

packages/services/faker/src/ops/user.rs Outdated Show resolved Hide resolved

packages/services/user/Cargo.toml Outdated Show resolved Hide resolved

packages/services/user/tests/profile_validate.rs Show resolved Hide resolved

abcxff force-pushed the 01-22-feat_user_workflows_profile_set_signal branch from d1e1fb6 to fa080dd Compare February 10, 2025 23:08

abcxff force-pushed the 01-22-feat_users_user_wf_tests branch from cfaabb0 to 975b507 Compare February 10, 2025 23:08

NathanFlurry requested changes Feb 10, 2025

View reviewed changes

feat(users): user wf tests

0964bef

abcxff force-pushed the 01-22-feat_user_workflows_profile_set_signal branch from fa080dd to 277d41a Compare February 14, 2025 14:31

abcxff force-pushed the 01-22-feat_users_user_wf_tests branch from 975b507 to 0964bef Compare February 14, 2025 14:31

abcxff mentioned this pull request Feb 14, 2025

chore: move loops to oss #2031

Closed

greptile-apps bot reviewed Feb 14, 2025

View reviewed changes

abcxff mentioned this pull request Feb 16, 2025

feat(user): user one-off for users w/o wf #2036

Closed

NathanFlurry closed this Jun 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(users): user wf tests #1935

feat(users): user wf tests #1935

Uh oh!

abcxff commented Jan 22, 2025

Uh oh!

abcxff commented Jan 22, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages bot commented Jan 22, 2025 •

edited

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NathanFlurry left a comment

Uh oh!

abcxff commented Feb 14, 2025

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Feb 14, 2025

Uh oh!

greptile-apps bot Feb 14, 2025

Uh oh!

greptile-apps bot Feb 14, 2025

Uh oh!

greptile-apps bot Feb 14, 2025

Uh oh!

greptile-apps bot Feb 14, 2025

Uh oh!

Uh oh!

feat(users): user wf tests #1935

feat(users): user wf tests #1935

Uh oh!

Conversation

abcxff commented Jan 22, 2025

Changes

Uh oh!

abcxff commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

cloudflare-workers-and-pages bot commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet with Cloudflare Pages

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NathanFlurry left a comment

Choose a reason for hiding this comment

Uh oh!

abcxff commented Feb 14, 2025

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

greptile-apps bot Feb 14, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 14, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 14, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 14, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

abcxff commented Jan 22, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 22, 2025 •

edited

Loading