feat(user/workflows): profile set signal #1902

ABCxFF · 2025-01-22T03:35:16Z

Changes

cloudflare-workers-and-pages · 2025-01-22T03:35:17Z

Deploying rivet with Cloudflare Pages

Latest commit:	`277d41a`
Status:	✅ Deploy successful!
Preview URL:	https://d2682d7f.rivet.pages.dev
Branch Preview URL:	https://01-22-feat-user-workflows-pr.rivet.pages.dev

View logs

ABCxFF · 2025-01-22T03:35:26Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

greptile-apps

PR Summary

This PR implements a profile update workflow with improved error handling and status reporting. Here's a summary of the key changes:

Added subscription-based profile update flow in /packages/api/identity/src/route/identities.rs using ProfileSetStatus messages
Implemented ProfileSet signal handler in /packages/services/user/src/workflows/user/mod.rs with validation and analytics tracking
Added dynamic query building for profile updates that only modifies specified fields
Introduced proper error handling for validation failures and missing parameters
Implemented cache invalidation after successful profile updates

The changes establish a more robust workflow for handling user profile updates with better status tracking and error reporting capabilities.

_{3 file(s) reviewed, 3 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

packages/api/identity/src/route/identities.rs

packages/services/user/src/workflows/user/mod.rs

NathanFlurry

profile_set should not dynamically build queries

ABCxFF · 2025-02-14T22:36:40Z

@greptileai

greptile-apps

PR Summary

This PR updates the profile set functionality to use a more structured approach with SQL COALESCE. Here's what's new:

Replaced dynamic query building with fixed COALESCE-based SQL update in /packages/services/user/src/workflows/user/mod.rs
Added proper SQL parameter handling for optional profile fields (display_name, account_number, bio)
Maintained existing validation, error handling and analytics tracking from previous implementation

The changes follow the review feedback to avoid dynamic query building while preserving the workflow's core functionality.

_{3 file(s) reviewed, 4 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-02-14T22:37:15Z

packages/api/identity/src/route/identities.rs

+	let mut sub = ctx
+		.subscribe::<::user::workflows::user::ProfileSetStatus>(("user_id", user_ent.user_id))
+		.await?;
+
+	ctx.signal(::user::workflows::user::ProfileSet {
 		display_name: body.display_name.clone(),
 		account_number: body.account_number.map(|n| n.api_try_into()).transpose()?,
 		bio: body.bio.clone(),
 	})
+	.tag("user_id", user_ent.user_id)
+	.send()
 	.await?;
-
+
+	let status_msg = sub.next().await?;
+	ensure!(status_msg.res.is_ok(), "bad profile set request");


logic: No timeout specified for subscription - could potentially hang indefinitely waiting for status message

greptile-apps · 2025-02-14T22:37:16Z

packages/api/identity/src/route/identities.rs

-
+
+	let status_msg = sub.next().await?;
+	ensure!(status_msg.res.is_ok(), "bad profile set request");


style: Generic error message 'bad profile set request' doesn't provide useful information about what failed

greptile-apps · 2025-02-14T22:37:20Z

packages/services/user/src/workflows/user/mod.rs

+		return Ok(Err(ProfileSetError::ValidationFailure));
+	}
+
+	ctx.cache().purge("user", [input.user_id]).await?;


logic: cache purge should happen after successful SQL update to prevent race conditions

greptile-apps · 2025-02-14T22:37:20Z

packages/services/user/src/workflows/user/mod.rs

+					if res.is_ok() {
+						ctx.activity(PublishProfileSetAnalyticsInput {
+							user_id
+						}).await?;
+
+						ctx.msg(Update {})
+							.tag("user_id", user_id)
+							.send()
+							.await?;
+					}


style: consider moving Update message before analytics to ensure data consistency

This was referenced Jan 22, 2025

chore(services/user): migrate user-team-list proto op #1650

Open

chore(users): migrate proto backend to native #1805

Open

chore(users/workflow): setup basic e2e user workflow #1844

Open

ABCxFF mentioned this pull request Jan 22, 2025

feat(users): user wf tests #1935

Open

ABCxFF force-pushed the 01-14-chore_users_workflow_setup_basic_e2e_user_workflow branch from 81d5185 to f4db43b Compare January 22, 2025 21:11

ABCxFF force-pushed the 01-22-feat_user_workflows_profile_set_signal branch from c562f66 to 7c0e8aa Compare January 22, 2025 21:11

ABCxFF force-pushed the 01-14-chore_users_workflow_setup_basic_e2e_user_workflow branch from f4db43b to af2ba81 Compare January 22, 2025 22:19

ABCxFF force-pushed the 01-22-feat_user_workflows_profile_set_signal branch from 7c0e8aa to c70fe90 Compare January 22, 2025 22:19

ABCxFF force-pushed the 01-14-chore_users_workflow_setup_basic_e2e_user_workflow branch from af2ba81 to 3672e0e Compare January 28, 2025 18:50

ABCxFF force-pushed the 01-22-feat_user_workflows_profile_set_signal branch from c70fe90 to e62fbcd Compare January 28, 2025 18:50

ABCxFF force-pushed the 01-14-chore_users_workflow_setup_basic_e2e_user_workflow branch from 3672e0e to 9e1d115 Compare January 28, 2025 19:50

ABCxFF force-pushed the 01-22-feat_user_workflows_profile_set_signal branch from e62fbcd to f129825 Compare January 28, 2025 19:50

ABCxFF mentioned this pull request Jan 28, 2025

feat(user): migrate pub/sub #1953

Open

ABCxFF force-pushed the 01-14-chore_users_workflow_setup_basic_e2e_user_workflow branch from 9e1d115 to d82712e Compare January 28, 2025 19:59

ABCxFF force-pushed the 01-22-feat_user_workflows_profile_set_signal branch from f129825 to af1c2e9 Compare January 28, 2025 19:59

ABCxFF force-pushed the 01-14-chore_users_workflow_setup_basic_e2e_user_workflow branch from d82712e to be3bf88 Compare January 28, 2025 22:35

ABCxFF force-pushed the 01-22-feat_user_workflows_profile_set_signal branch from af1c2e9 to 1854f2f Compare January 28, 2025 22:35

ABCxFF mentioned this pull request Jan 29, 2025

chore(users): delete old worker code #1959

Open

ABCxFF force-pushed the 01-14-chore_users_workflow_setup_basic_e2e_user_workflow branch from be3bf88 to bfa5ec7 Compare February 6, 2025 21:51

ABCxFF force-pushed the 01-22-feat_user_workflows_profile_set_signal branch from 1854f2f to 65dbb93 Compare February 6, 2025 21:51

ABCxFF force-pushed the 01-14-chore_users_workflow_setup_basic_e2e_user_workflow branch from bfa5ec7 to 3c1eb2f Compare February 6, 2025 21:57

ABCxFF force-pushed the 01-22-feat_user_workflows_profile_set_signal branch from 65dbb93 to d1e1fb6 Compare February 6, 2025 21:57

ABCxFF marked this pull request as ready for review February 10, 2025 19:37

greptile-apps bot reviewed Feb 10, 2025

View reviewed changes

packages/api/identity/src/route/identities.rs Outdated Show resolved Hide resolved

packages/services/user/src/workflows/user/mod.rs Outdated Show resolved Hide resolved

packages/services/user/src/workflows/user/mod.rs Show resolved Hide resolved

ABCxFF force-pushed the 01-14-chore_users_workflow_setup_basic_e2e_user_workflow branch from 3c1eb2f to f8405d0 Compare February 10, 2025 23:08

ABCxFF force-pushed the 01-22-feat_user_workflows_profile_set_signal branch from d1e1fb6 to fa080dd Compare February 10, 2025 23:08

NathanFlurry requested changes Feb 10, 2025

View reviewed changes

feat(user/workflows): profile set signal

277d41a

ABCxFF force-pushed the 01-14-chore_users_workflow_setup_basic_e2e_user_workflow branch from f8405d0 to ca89652 Compare February 14, 2025 14:31

ABCxFF force-pushed the 01-22-feat_user_workflows_profile_set_signal branch from fa080dd to 277d41a Compare February 14, 2025 14:31

ABCxFF mentioned this pull request Feb 14, 2025

chore: move loops to oss #2031

Open

greptile-apps bot reviewed Feb 14, 2025

View reviewed changes

ABCxFF mentioned this pull request Feb 16, 2025

feat(user): user one-off for users w/o wf #2036

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(user/workflows): profile set signal #1902

feat(user/workflows): profile set signal #1902

ABCxFF commented Jan 22, 2025

cloudflare-workers-and-pages bot commented Jan 22, 2025 •

edited

Loading

ABCxFF commented Jan 22, 2025 •

edited

Loading

greptile-apps bot left a comment

NathanFlurry left a comment

ABCxFF commented Feb 14, 2025

greptile-apps bot left a comment

greptile-apps bot Feb 14, 2025

greptile-apps bot Feb 14, 2025

greptile-apps bot Feb 14, 2025

greptile-apps bot Feb 14, 2025



		let status_msg = sub.next().await?;
		ensure!(status_msg.res.is_ok(), "bad profile set request");

feat(user/workflows): profile set signal #1902

Are you sure you want to change the base?

feat(user/workflows): profile set signal #1902

Conversation

ABCxFF commented Jan 22, 2025

Changes

cloudflare-workers-and-pages bot commented Jan 22, 2025 • edited Loading

Deploying rivet with Cloudflare Pages

ABCxFF commented Jan 22, 2025 • edited Loading

How to use the Graphite Merge Queue

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

NathanFlurry left a comment

Choose a reason for hiding this comment

ABCxFF commented Feb 14, 2025

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Feb 14, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 14, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 14, 2025

Choose a reason for hiding this comment

greptile-apps bot Feb 14, 2025

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented Jan 22, 2025 •

edited

Loading

ABCxFF commented Jan 22, 2025 •

edited

Loading