refactor: optimize dx experience for Max #2243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rivet-hub with
|
| Latest commit: |
a368c6b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4eaa8970.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://03-21-refactor-optimize-dx-e.rivet-hub-7jb.pages.dev |
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Optimized development experience by pre-bundling Font Awesome and Rivet icons dependencies in Vite configuration to reduce runtime processing overhead.
- Added
@fortawesome/*and@rivet-gg/iconstooptimizeDeps.includeinfrontend/apps/hub/vite.config.tsfor faster dev server startup - Updated
@rivet-gg/iconspackage to use React 19 as peer dependency - Configured
commonjsOptions.includeto properly handle icon dependencies in build process - Added
sideEffects: falseflag in icon package for better tree-shaking
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Deploying rivet with
|
| Latest commit: |
a368c6b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cca4c05e.rivet.pages.dev |
| Branch Preview URL: | https://03-21-refactor-optimize-dx-e.rivet.pages.dev |
MasterPtato
approved these changes
Mar 21, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 23, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> @MasterPtato a gift for you ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the
03-21-refactor_optimize_dx_experience_for_max
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MasterPtato a gift for you
Changes