Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Static Variable from rzasm #4100

Merged
merged 9 commits into from
Jan 16, 2024
Merged

Conversation

HN026
Copy link
Contributor

@HN026 HN026 commented Jan 12, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

...

Closing issues

Partially addresses #4055

librz/include/rz_asm.h Outdated Show resolved Hide resolved
@XVilka XVilka added this to the 0.7.0 milestone Jan 13, 2024
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I mean is using plugin-specific context instead, just like it's done in Tricore plugin

@HN026
Copy link
Contributor Author

HN026 commented Jan 14, 2024

What I mean is using plugin-specific context instead, just like it's done in Tricore plugin

Okay Sure

librz/include/rz_asm.h Outdated Show resolved Hide resolved
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is the way of doing it. Thank you!

@XVilka
Copy link
Member

XVilka commented Jan 15, 2024

@HN026 next time don't forget to refer to the corresponding issue in the PR body. If it fully solves it "Closes #XXX" if only partially - "Partially addresses #XXX" so that GitHub performs necessary chores automatically.

@XVilka XVilka merged commit 3c52065 into rizinorg:dev Jan 16, 2024
44 checks passed
@HN026
Copy link
Contributor Author

HN026 commented Jan 16, 2024

@HN026 next time don't forget to refer to the corresponding issue in the PR body. If it fully solves it "Closes #XXX" if only partially - "Partially addresses #XXX" so that GitHub performs necessary chores automatically.

Okayyyy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants