Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scr.rainbow option #4199

Merged
merged 2 commits into from
Feb 10, 2024
Merged

Remove scr.rainbow option #4199

merged 2 commits into from
Feb 10, 2024

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Feb 9, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Removed scr.rainbow whose usefulness is highly doubtful also it messes colors from the colortheme:

With e scr.rainbow=true

Screenshot 2024-02-09 at 11 17 04 PM

Without scr.rainbow (the default state)

Screenshot 2024-02-09 at 11 18 09 PM

Test plan

CI is green

Partially addresses #4055

@XVilka XVilka force-pushed the asan-remove-scr-rainbow branch from f9fcb63 to a95df22 Compare February 9, 2024 15:21
@XVilka XVilka force-pushed the asan-remove-scr-rainbow branch 4 times, most recently from 03504d5 to 6419555 Compare February 9, 2024 15:58
librz/util/float/float.c Outdated Show resolved Hide resolved
@XVilka XVilka merged commit 8e4faa3 into dev Feb 10, 2024
15 of 19 checks passed
@XVilka XVilka deleted the asan-remove-scr-rainbow branch February 10, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants