core/disasm: remove static variables #4214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XVilka
requested review from
wargio,
kazarmy,
thestr4ng3r and
ret2libc
as code owners
XVilka
force-pushed
the
asan-remove-core-global
branch
2 times, most recently
from
b5d01db to
1a761cd
Compare
XVilka
force-pushed
the
asan-remove-core-global
branch
4 times, most recently
from
1a63bc0 to
282573d
Compare
wargio
reviewed
Feb 12, 2024
wargio
reviewed
Feb 12, 2024
wargio
reviewed
Feb 12, 2024
| * | ||
| * It considers space, TAB, and newline characters as the whitespace | ||
| */ | ||
| RZ_API const char *rz_str_trim_head_ro(RZ_NONNULL const char *str) { |
There was a problem hiding this comment.
This should really be named rz_str_first_non_whitespace. i will open a PR after this is merged
wargio
reviewed
Feb 12, 2024
| * | ||
| * It considers only space and TAB as the whitespace | ||
| */ | ||
| RZ_API const char *rz_str_trim_head_wp(RZ_NONNULL const char *str) { |
XVilka
force-pushed
the
asan-remove-core-global
branch
from
282573d to
5e8481f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
A small cleanup. A downside - slightly worse performance of the disassembly.
Test plan
CI is green
Closing issues
Partially addresses #4055