Add flag to build packages in debug mode #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase! Other PR merged in main :) |
Done and done :D |
ret2libc
reviewed
Apr 2, 2024
Comment on lines
+119
to
+121
| if isInstalled == "yes" { | ||
| fmt.Printf("Install location: %s\n", filepath.Join(site.GetArtifactsDir(), pkg.Source().Directory)) | ||
| } |
There was a problem hiding this comment.
Isn't this the "build" directory?
|
Seems good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys. Thanks again for the wonderful tool. This PR allows the user to choose whether to do a debug build or not. I'm currently debugging a package and tinkering with it a bit. This PR allows me to do this without modifying the rz-pm codebase.
This PR is based off of #53. I did so since PR #53 was accepted (and we're just finalizing a couple of comments). Do look at that one before this one.
Lemme know if you agree. Cheers and many thanks ❤️