Test #1
Open
Test #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing unit test for D_
The typo can be seen in the diff.
Fixing permissions for one file
Fix typo in Readme.md
make cache-class configurable
Fix typo in base.rb
drop rubies before 2.7
Running the test suite with RUBYOPT="--enable-frozen-string-literal" simulates Ruby's future behavior having frozen string on by default. This fixed the error that happens with this option enabled by marking two strings which are mutated as mutable with the + operator.
Mark mutable strings as mutable
run with frozen strings in ci
…nt behavior Previously String#% was overridden on versions after Ruby 1.9 to match the 1.8 behavior where missing keys in the expanded format are ignored and not replaced. This is likely suprising behavior in modern Ruby. This removes the previous patch, but still allows overriding this behavior optionally by calling `FastGettext.allow_invalid_keys!`.
Convert String#% to Ruby 1.9+ behavior with option use maintain current behavior
bump ruby
a small warning, while running in `$VERBOSE` mode: ``` gems/fast_gettext-4.1.0/lib/fast_gettext/vendor/mofile.rb:182: warning: assigned but unused variable - i ```
drop unused local variable in vendor/mofile.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update latest fast_get txt into my extension