Skip to content

Conversation

@rjcorwin
Copy link
Owner

Summary

  • migrate the CLI source tree from CommonJS JavaScript to TypeScript, including the entrypoint and command modules
  • add a dedicated TypeScript configuration for the CLI, update the package manifest to build to dist/, and point the bin stub at the compiled output
  • refresh the EnhancedInput, key handling utilities, and related tests to work with the compiled TypeScript artifacts

Testing

  • npm run build
  • npm run test --workspace cli

https://chatgpt.com/codex/tasks/task_e_68dbcadf61148325b50db9a1ec1b5196

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment on lines +367 to +371
useKeypress((key) => {
if (disabled) return;

const command = getCommand(key as any, keyBindings);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Disabled input still consumes terminal shortcuts

EnhancedInput now calls useKeypress without passing an isActive option (lines 367‑371). Because useKeypress defaults to isActive = true and preventDefault = true, the hook continues to capture keypresses even when the component is rendered with disabled and suppresses Ctrl/⌘ combinations. In the advanced interactive UI the input is disabled while pending operations are being confirmed, so users can no longer use Ctrl+C or other terminal shortcuts to abort until the input is re‑enabled. The previous implementation gated the hook with { isActive: !disabled }; restoring that guard would keep terminal shortcuts functional when the input is inactive.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants