fresh version of alpine and s3fs on tiny image #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjocoleman
reviewed
Feb 1, 2017
| @@ -6,8 +6,6 @@ IFS=$'\n\t' | |||
|
|
|||
| export S3_ACL=${S3_ACL:-private} | |||
|
|
|||
| test $MOUNT_POINT | |||
| rm -rf ${MOUNT_POINT} | |||
There was a problem hiding this comment.
@andrius what's your rationale here? S3FS will fail to mount if the mountpoint isn't empty?
There was a problem hiding this comment.
@rjocoleman I get an error on first run with original version of docker-compose.sh. Actually my PR is just about Dockerfile, docker-entrypoint.sh is a quickfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we don't need *dev packages after install, so I removed them to make smallest docker image