Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rules concepts] Add triggers & conditions #4
[Rules concepts] Add triggers & conditions #4
Changes from 2 commits
58d8576
dc7e36f
62de18a
e953978
d5bcb18
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like having a reference here. The Actions page seems to be an odd place to have the canonical explanation for the difference between a command and an update. But the only other two places where it's explained is on the Items page where I don't think it's explained very well, and the Rules page which I think has the best description: https://www.openhab.org/docs/configuration/rules-dsl.html#manipulating-item-states.
Given that we are rewriting both the Rules and the Actions pages anyway, this reference will become different before we are done. So at a minimum we should put a TODO here so we remember to come back and fix the reference later.
But I think we will be better off if we move and augment the description of the difference between updates and commands to Items and reference that here, or put it here and reference to here in the rewritten Actions and Rules pages (perhaps even the Items page too).
Does the ":::tip" show up in the table of contents and support direct linking? If so, maybe it could be another tip section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to have this at Items, as it is the most logical page for me.
I don‘t know, sorry. Shouldn‘t matter when we have the explanation at Items.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just checked the docs, https://www.openhab.org/docs/configuration/items.html#command-vs-status might help??
Anyway, I decided to explain the difference directly in the concepts page since it‘s a one liner.