Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull request #1

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

pull request #1

wants to merge 10 commits into from

Conversation

abefan2019
Copy link

I just add some functions to my fork. I want to merge it to your code.

support the url that begin with "dailygh"
support the url that begin with "dailygh"
prevent download the repeat file in the list
remove the repeat part
download the video again if it's corrupt
separate temp file and final file
delete temp file
choose seasons
Copy link
Owner

@rkwyu rkwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The temporary output can help avoid confusion due to incomplete downloads. However, removing os.path.exists might lead to redundant downloads, even if the file already exists in the target directory.

@abefan2019
Copy link
Author

"os.path.exists" is repeated.
Here is the code from anime_dl.py

try:
    ffmpeg.input(fp).output('x.png', vframes=0, loglevel="quiet").run() #check if the video is exist and not damaged
except ffmpeg._run.Error:
    try:
        os.remove(fp)
    except:
        pass
    try:
        os.remove(fpt)
    except:
        pass
    video_url_validator.validate(episode)
    downloader.download(episode)
else:
    print("Skip "+fn+" (downloaded)") #the downloads will be skip if it's exist and not damaged. so it won't cause redundant downloads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants