-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pull request #1
Open
abefan2019
wants to merge
10
commits into
rkwyu:main
Choose a base branch
from
abefan2019:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
pull request #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support the url that begin with "dailygh"
support the url that begin with "dailygh"
prevent download the repeat file in the list
remove the repeat part
download the video again if it's corrupt
Bugs fix
Bugs fix
separate temp file and final file
delete temp file
choose seasons
rkwyu
reviewed
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The temporary output can help avoid confusion due to incomplete downloads. However, removing os.path.exists might lead to redundant downloads, even if the file already exists in the target directory.
"os.path.exists" is repeated. try:
ffmpeg.input(fp).output('x.png', vframes=0, loglevel="quiet").run() #check if the video is exist and not damaged
except ffmpeg._run.Error:
try:
os.remove(fp)
except:
pass
try:
os.remove(fpt)
except:
pass
video_url_validator.validate(episode)
downloader.download(episode)
else:
print("Skip "+fn+" (downloaded)") #the downloads will be skip if it's exist and not damaged. so it won't cause redundant downloads |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just add some functions to my fork. I want to merge it to your code.